New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filters #649

Merged

zyxkad merged 4 commits into IntelligenceModding:dev/1.19.2 from zyxkad:filter-patch

Aug 8, 2024

Collaborator

zyxkad commented Jul 21, 2024 •

edited

Loading

fix filters
remove some unnecessary ItemStack.copy()s

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

Please check if the PR fulfills these requirements

The commit message are well described
Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
All changes have fully been tested

What kind of change does this PR introduce? (Bug fix, feature, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
- NBT Filters are broken (Forge, 1.20.1) #648
Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
n/a
Other information:
Should return null and not found error instead of Item.AIR?

zyxkad added 3 commits

July 21, 2024 10:31


          fix filters

e07ec4b


          remove some unnecessary ItemStack.copy()s

7ac8f69


          return nil instead of empty item for getItem

a80ac92

zyxkad requested a review from SirEndii

July 21, 2024 19:40


          remove trailing space

e61c391

SirEndii approved these changes

View reviewed changes

zyxkad merged commit 4ee4f91 into IntelligenceModding:dev/1.19.2

2 checks passed

zyxkad linked an issue

that may be closed by this pull request

NBT Filters are broken (Forge, 1.20.1) #648

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet