Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow operation cooldown to be 0 #668

Merged

Conversation

Niki4tap
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message are well described (they are ok, can be amended if strictly necessary)
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Allows for the cooldown to be set to 0, the default cooldown is still the same, so this doesn't change anything for most players, and allows for the folks who know what they're doing to lift the cooldown altogether.

  • What is the current behavior? (You can also link to an open issue here)
    Cooldown is set to at least 1000, and currently cannot be lower (unless you are going to patch the mod which I did in my survival world but wanted to upstream the changes)

  • What is the new behavior (if this is a feature change)?
    Described above.

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    None, config change.

  • Other information:
    It's fine if this change cannot be upstreamed due to security concerns or whatever, I can still patch and build the mod myself for my worlds, but the cooldown can really get annoying if you're using the vanilla mod, and especially busy looping to wait for a message to leave the computer and sent in the chat makes the players want to code some sort of a "message sender domain" which is crazy as hell for this small thing, but is necessary for the correct and timely operation of computers, or if one trusts every computer on the server (you're playing only with a friend, not a public server), you could just lift the cooldown altogether and stop worrying about it.

@Niki4tap Niki4tap changed the title allow cooldown to be 0 Allow operation cooldown to be 0 Nov 21, 2024
@SirEndii SirEndii merged commit c535fab into IntelligenceModding:dev/1.20.1 Nov 25, 2024
2 checks passed
@SirEndii
Copy link
Member

Thank you for the contribution, but please keep in mind for the next time to make your changes for the oldest fully supported version as stated in the guidelines

@Niki4tap
Copy link
Contributor Author

Ah, sorry, do you mean targeting the PR for the older branch? Should I rebase #667 in that case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants