Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue 457 #472

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Fixed issue 457 #472

merged 2 commits into from
Feb 19, 2025
+38 −2

Conversation

HeinzBaumann
Copy link
Collaborator

Added additional test cases to test to handle the two use cases:

  • vendor has no purposes consent and no LI but special purposes specified. The LI bit should be 1.
  • vendor has purpose consent, no LI but special purposes specified. The LI git should be 1.

Update the code in SemanticPreEncoder to ensure in these two use cases the LI bit is actually set for the vendor.

@HeinzBaumann HeinzBaumann mentioned this pull request Jan 14, 2025
Closed
@aitnitishshelage aitnitishshelage merged commit c8abbb7 into master Feb 19, 2025
1 check passed
@aitnitishshelage aitnitishshelage deleted the issue-457 branch February 19, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schavvaOt schavvaOt schavvaOt approved these changes

@sbanerjee97 sbanerjee97 sbanerjee97 approved these changes

@sevriugin sevriugin Awaiting requested review from sevriugin

@lamrowena lamrowena Awaiting requested review from lamrowena

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HeinzBaumann @schavvaOt @sbanerjee97 @aitnitishshelage