Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more verbose logging on syncread failures #15

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

lukeschmitt-tr
Copy link
Member

@lukeschmitt-tr lukeschmitt-tr commented Jun 27, 2024

This PR does the following:

  • Makes read failures more descriptive
  • Adds an additional check where, if any read fails, check what motors we are failing to read from.
  • Allows users to define joint state publisher behavior on read failures - opting to use the values provided by dxl_wb (-pi), or using NaN values; the former being the default.

This change will make it easier to diagnose connection problems between motors and better help to detect faulty motors.

Brings in the feature from the ROS 1 SDK added in Interbotix/interbotix_ros_core#44 and Interbotix/interbotix_ros_core#46

@lukeschmitt-tr lukeschmitt-tr merged commit d8a73f6 into ros2 Jul 9, 2024
3 checks passed
@lukeschmitt-tr lukeschmitt-tr deleted the syncread_error branch July 9, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant