Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GHC 9.12. #80

Merged
merged 6 commits into from
Dec 28, 2024
Merged

Support GHC 9.12. #80

merged 6 commits into from
Dec 28, 2024

Conversation

jonathanknowles
Copy link
Contributor

This PR:

  • adds GHC 9.12 to the CI build matrix.
  • bumps upper version bounds of the following dependencies:
    • base
    • extra
    • template-haskell
  • bumps the minor version of both bech32 and bech32-th.

I'd be happy to release these updates to Hackage (I'm a maintainer for both bech32 and bech32-th packages).

Thanks!

@jonathanknowles
Copy link
Contributor Author

jonathanknowles commented Dec 27, 2024 •
edited
Loading

I think the GitHub action workflow needs to be re-enabled for this repository -- it looks like it was automatically disabled after 60 days of inactivity.

In the meantime, I tested the CI updates here: https://github.com/jonathanknowles/bech32/actions/runs/12510498672

HeinrichApfelmus
HeinrichApfelmus approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Jonathan! 😊

(It's unclear to me who is responsible for this repository now, but I'm happy to approve this.)

Unisay
Unisay approved these changes Dec 27, 2024
View reviewed changes
Copy link

@Unisay Unisay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathanknowles
Copy link
Contributor Author

Thanks @HeinrichApfelmus, @Unisay!

Please could one of you hit the "Merge pull request" button? 🙏🏻

After that, I can release to Hackage.

@HeinrichApfelmus HeinrichApfelmus added this pull request to the merge queue Dec 28, 2024
Merged via the queue into IntersectMBO:master with commit 5e8d1ae Dec 28, 2024
2 checks passed
@jonathanknowles
Copy link
Contributor Author

@HeinrichApfelmus thanks!

@jonathanknowles
Copy link
Contributor Author

Updates published here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unisay Unisay Unisay approved these changes

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

@Anviking Anviking Awaiting requested review from Anviking Anviking is a code owner

@paweljakubas paweljakubas Awaiting requested review from paweljakubas paweljakubas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathanknowles @HeinrichApfelmus @Unisay