Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for DRep metadata size #569

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

CarlosLopezDeLara
Copy link
Contributor

Changelog

- description: |
    https://cips.cardano.org/cip/CIP-0119 proposes using a schema where the basic jsonld structure is heavier than 512. The agreement is that DBsync will set a limit for the size of metadata that is downloaded into the DB, but API or CLI do not need to impose any restrictions.
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

https://cips.cardano.org/cip/CIP-0119 proposes using a schema where the basic jsonld structure is heavier than 512.
cardano-foundation/CIPs#835

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@CarlosLopezDeLara CarlosLopezDeLara force-pushed the cl/drepmetadata branch 2 times, most recently from c2ecc7d to ec840fa Compare July 1, 2024 16:18
@CarlosLopezDeLara CarlosLopezDeLara force-pushed the cl/drepmetadata branch 2 times, most recently from a94575d to 7ce119e Compare July 3, 2024 19:02
@CarlosLopezDeLara CarlosLopezDeLara marked this pull request as ready for review July 3, 2024 19:22
Remove check for DRep metadata size

https://cips.cardano.org/cip/CIP-0119 proposes using a schema where the basic jsonld structure is heavier than 512.

The agreement is that DBsync will set a limit for the size of metadata that is downloaded into the DB, but API or CLI do not need to impose any restrictions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants