Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] - Make output of CLI commands consistent. #566

Open
carbolymer opened this issue Jan 12, 2024 · 13 comments
Open

[FR] - Make output of CLI commands consistent. #566

carbolymer opened this issue Jan 12, 2024 · 13 comments

Comments

@carbolymer
Copy link
Contributor

Internal/External
Internal if an IOHK staff member.

Area
Other Any other topic (Delegation, Ranking, ...).

Describe the feature you'd like
Currently the output format of the CLI commands may depend on multiple things and sometimes is not deterministic. This may surprise the users and lead to a poor user experience (like in #537 ).

An example is cardano-cli conway query ledger-state:


where the output format depends on where you would like to send it (binary CBOR for file, json for stdout) and if there was and error when decoding it (plain CBOR when error occurred during CBOR deserialization into JSON).

A one way to make it consistent across the whole CLI is to use similar output flags to transaction-view like in #523.

This comment was marked as outdated.

This comment was marked as off-topic.

This comment was marked as outdated.

This comment was marked as off-topic.

@github-actions github-actions bot added the Stale label May 16, 2024
@smelc smelc removed the Stale label May 16, 2024

This comment was marked as off-topic.

@github-actions github-actions bot added the Stale label Jun 16, 2024
@smelc smelc removed the Stale label Jun 17, 2024

This comment was marked as outdated.

This comment was marked as outdated.

@github-actions github-actions bot added the Stale label Aug 19, 2024
@smelc smelc removed the Stale label Aug 19, 2024

This comment was marked as off-topic.

@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Sep 19, 2024

We are toying with the idea of exposing the remaining mini-protocols via an HTTP server. We currently have the cardano-submit-api which exposes transaction submission in this fashion and we could do the same for node queries etc. This also allows us to generate an OpenAPI spec "for free" with https://hackage.haskell.org/package/servant-openapi3 and we can reuse these JSON instances in the cardano-cli which also inherits an OpenAPI spec "for free".

This comment was marked as off-topic.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Nov 22, 2024
@smelc smelc removed the Stale label Nov 22, 2024
@smelc
Copy link
Contributor

smelc commented Nov 27, 2024

Witnessing with @CarlosLopezDeLara today that era transaction txid would benefit of adding --output-json and --output-text.

@smelc
Copy link
Contributor

smelc commented Nov 29, 2024

#982 shows that hash genesis-file would also benefit of this improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants