-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove orphan instance #1004
Remove orphan instance #1004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a build failure
@@ -397,7 +397,7 @@ runTransactionBuildEstimateCmd -- TODO change type | |||
, txBodyOutFile | |||
} = do | |||
let sbe = convert currentEra | |||
meo = convert currentEra | |||
meo = convert (convert currentEra :: BabbageEraOnwards era) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not also implement:
instance Convert Era MaryEraOnwards where
We can avoid calling convert
twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the original issue, wasn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is what we want to avoid indeed 😄
cfc6068
to
1db2081
Compare
1db2081
to
c176396
Compare
c176396
to
ff15908
Compare
Changelog
Context
Follow-up of @carbolymer's remark: IntersectMBO/cardano-api#701 (comment)
How to trust this PR
It still compiles
Checklist