Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove orphan instance #1004

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Remove orphan instance #1004

merged 1 commit into from
Jan 7, 2025

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jan 6, 2025

Changelog

- description: |
    Remove orphan instance
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Follow-up of @carbolymer's remark: IntersectMBO/cardano-api#701 (comment)

How to trust this PR

It still compiles

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a build failure

@@ -397,7 +397,7 @@ runTransactionBuildEstimateCmd -- TODO change type
, txBodyOutFile
} = do
let sbe = convert currentEra
meo = convert currentEra
meo = convert (convert currentEra :: BabbageEraOnwards era)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not also implement:

instance Convert Era MaryEraOnwards where

We can avoid calling convert twice.

Copy link
Contributor

@carbolymer carbolymer Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the original issue, wasn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is what we want to avoid indeed 😄

@smelc smelc force-pushed the smelc/remove-orphan-instance branch from cfc6068 to 1db2081 Compare January 7, 2025 09:40
@smelc smelc enabled auto-merge January 7, 2025 09:45
@smelc smelc force-pushed the smelc/remove-orphan-instance branch from 1db2081 to c176396 Compare January 7, 2025 10:41
@smelc smelc force-pushed the smelc/remove-orphan-instance branch from c176396 to ff15908 Compare January 7, 2025 14:03
@smelc smelc added this pull request to the merge queue Jan 7, 2025
Merged via the queue into master with commit 29b13af Jan 7, 2025
72 of 78 checks passed
@smelc smelc deleted the smelc/remove-orphan-instance branch January 7, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants