Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to removal of some patterns in API #1020

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jan 16, 2025

Changelog

- description: |
    Adapt to removal of patterns in API
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

CLI adaptation to IntersectMBO/cardano-api#728

How to trust this PR

Tests still pass

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc added the next-update Needs a dependency to be updated to be merged label Jan 16, 2025
@smelc smelc changed the title Adapt to removal of patterns in API Adapt to removal of some patterns in API Jan 16, 2025
@smelc smelc force-pushed the smelc/adapt-to-API-pattern-removal branch from f934505 to ee8717c Compare January 23, 2025 10:46
@smelc smelc force-pushed the smelc/adapt-to-API-pattern-removal branch 2 times, most recently from e1b81b3 to 19e6ef6 Compare January 29, 2025 09:00
@smelc smelc enabled auto-merge January 29, 2025 09:00
@smelc smelc added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 29, 2025
@smelc smelc added this pull request to the merge queue Jan 29, 2025
Merged via the queue into master with commit e55e28e Jan 29, 2025
25 checks passed
@smelc smelc deleted the smelc/adapt-to-API-pattern-removal branch January 29, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-update Needs a dependency to be updated to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants