Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ShelleyMode and ByronMode #404

Merged
merged 7 commits into from
Oct 28, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Oct 26, 2023

Changelog

- description: |
    Remove `ShelleyMode` and `ByronMode`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

We no longer use ShelleyMode and ByronMode and they can be removed.

The removal of these modes results in significant simplification of the CLI codebase.

These modes still exist in cardano-api. They are removed in cardano-node first to minimise dependency risk.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/remove-shelley-mode-and-byron-mode branch from 6e61ba0 to 09fc1f8 Compare October 26, 2023 10:21
@newhoggy newhoggy marked this pull request as ready for review October 26, 2023 10:21
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -52,12 +47,7 @@ data TxCmdError
| TxCmdWitnessEraMismatch !AnyCardanoEra !AnyCardanoEra !WitnessFile
| TxCmdPolicyIdsMissing ![PolicyId]
| TxCmdPolicyIdsExcess ![PolicyId]
| TxCmdUnsupportedMode !AnyConsensusMode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Copy link
Contributor

@mkoura mkoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression tests passed ✔️

@newhoggy newhoggy force-pushed the newhoggy/remove-shelley-mode-and-byron-mode branch from 9beabb4 to 445d892 Compare October 28, 2023 03:49
@newhoggy newhoggy enabled auto-merge October 28, 2023 03:50
@newhoggy newhoggy added this pull request to the merge queue Oct 28, 2023
Merged via the queue into main with commit 096bb69 Oct 28, 2023
19 checks passed
@newhoggy newhoggy deleted the newhoggy/remove-shelley-mode-and-byron-mode branch October 28, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants