-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ShelleyMode
and ByronMode
#404
Conversation
6e61ba0
to
09fc1f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -52,12 +47,7 @@ data TxCmdError | |||
| TxCmdWitnessEraMismatch !AnyCardanoEra !AnyCardanoEra !WitnessFile | |||
| TxCmdPolicyIdsMissing ![PolicyId] | |||
| TxCmdPolicyIdsExcess ![PolicyId] | |||
| TxCmdUnsupportedMode !AnyConsensusMode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression tests passed ✔️
9beabb4
to
445d892
Compare
Changelog
Context
We no longer use
ShelleyMode
andByronMode
and they can be removed.The removal of these modes results in significant simplification of the CLI codebase.
These modes still exist in
cardano-api
. They are removed incardano-node
first to minimise dependency risk.How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist