Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golden test for creating TxOut with inline datum #408

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

mkoura
Copy link
Contributor

@mkoura mkoura commented Oct 27, 2023

Changelog

- description: |
    Add golden test for creating TxOut with inline datum
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Tests fix implemented in #407

How to trust this PR

The new test passes with changes made in #407 and fails on older main with the expected error.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I should've added that with the fix.

@disassembler disassembler added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 12b3bba Oct 30, 2023
20 checks passed
@disassembler disassembler deleted the mkoura/add_inline_datum_txout_test branch October 30, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants