Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol-(major|minor)-version disappears in conway's create-protocol-parameters-update command #437

Closed

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 6, 2023

Warning

Requires IntersectMBO/cardano-api#358 merged and released to build

Changelog

- description: |
    --protocol-(minor|major)-version cannot be changed via create-protocol-parameters-update command in conway
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #388

How to trust this PR

  • Observe the diff in golden files is as expected

Roadmap to merge

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc
Copy link
Contributor Author

smelc commented Nov 10, 2023

Integrated in #435 in the end, so closing

@smelc smelc closed this Nov 10, 2023
@smelc smelc deleted the smelc/conway-protocol-version-change-not-common-anymore branch February 1, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove options from create-protocol-parameters-update
1 participant