Correct conway parser, so that --key-reg-deposit-amt is mandatory

[smelc]

Changelog

- description: |
    Make --key-reg-deposit-amt mandatory in the parser of conway stake-address registration-certificate, because it is actually mandatory.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #449

How to trust this PR

• Observe the change in golden files

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[carlhammann]

This looks good to me. I wonder whether #449 applies only to this command. Does it maybe also apply to conway drep registration-certificate and conway stake-address deregistration-certificate?

[carlhammann]

Also, maybe "bugfix" is applicable here?

[smelc]

Does it maybe also apply to conway drep registration-certificate and conway stake-address deregistration-certificate?

Good point @carlhammann 🙏 I had already checked that stake-address deregistration-certificate is unaffected. Let me check drep registration-certificate 👍

[smelc]

@carlhammann> nope it's all good, drep registration-certificate is not affected 👍