Byron isolation 2 of n #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/byron-isolation-2-of-n-final
branch
2 times, most recently
from
4421bcf to
67e9223
Compare
Jimbo4350
commented
Nov 20, 2023
| -- TODO: As a follow up we need to expose a simple tx building command that only | ||
| -- uses inputs, outputs and update proposals. NB: Update proposals are a separate | ||
| -- thing in the Byron era so we need to figure out how we are handling that at the | ||
| -- cli command level. |
There was a problem hiding this comment.
In a follow up PR we will remove support for the Byron era here.
Jimbo4350
commented
Nov 20, 2023
| @@ -930,8 +930,7 @@ runTransactionSignCmd | |||
| inputTxFile <- liftIO $ fileOrPipe inputTxFilePath | |||
| anyTx <- lift (readFileTx inputTxFile) & onLeft (left . TxCmdCddlError) | |||
|
|
|||
| InAnyShelleyBasedEra sbe tx <- | |||
| onlyInShelleyBasedEras "sign for Byron era transactions" anyTx | |||
| InAnyShelleyBasedEra sbe tx <- pure anyTx | |||
There was a problem hiding this comment.
We never supported Byron era tx signing. Indication that people were using the "old" cardano-cli byron cli commands for everything Byron related.
Jimbo4350
commented
Nov 20, 2023
| @@ -998,8 +997,8 @@ runTransactionSubmitCmd | |||
| , txFile | |||
| } = do | |||
| txFileOrPipe <- liftIO $ fileOrPipe txFile | |||
| InAnyCardanoEra era tx <- lift (readFileTx txFileOrPipe) & onLeft (left . TxCmdCddlError) | |||
| let txInMode = TxInMode era tx | |||
| InAnyShelleyBasedEra era tx <- lift (readFileTx txFileOrPipe) & onLeft (left . TxCmdCddlError) | |||
There was a problem hiding this comment.
QA confirmed they use the "old" cardano-cli byron commands to submit txs. Unlikely anybody else is using this command to submit byron era txs.
Jimbo4350
force-pushed
the
jordan/byron-isolation-2-of-n-final
branch
from
67e9223 to
c907b16
Compare
Jimbo4350
requested review from
newhoggy,
carbolymer,
kevinhammond and
disassembler
as code owners
Jimbo4350
force-pushed
the
jordan/byron-isolation-2-of-n-final
branch
2 times, most recently
from
a020a6b to
d704050
Compare
carbolymer
approved these changes
Nov 20, 2023
Jimbo4350
force-pushed
the
jordan/byron-isolation-2-of-n-final
branch
from
d704050 to
ebdfd13
Compare
Introduce Byron/Shelley split into runLegacyTransactionBuildRawCmd
The following functions never supported the Byron era: runTransactionSignCmd runTransactionCalculateMinFeeCmd runTransactionWitnessCmd
cardano-cli transaction submit cardano-cli transaction txid cardano-cli transaction view
Rename readFileInAnyCardanoEra to readFileInAnyShelleyBasedEra Modify CddlWitness to wrap InAnyShelleyBasedEra KeyWitness
Jimbo4350
force-pushed
the
jordan/byron-isolation-2-of-n-final
branch
2 times, most recently
from
026262a to
cebac91
Compare
Jimbo4350
force-pushed
the
jordan/byron-isolation-2-of-n-final
branch
from
cebac91 to
ffd8f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist