Github Action improvements #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
force-pushed
the
erikd/gha-tweaking
branch
2 times, most recently
from
9db8dbe to
d567e73
Compare
carbolymer
reviewed
Feb 26, 2024
erikd
force-pushed
the
erikd/gha-tweaking
branch
from
d567e73 to
ad2394d
Compare
* Make it more like `cardano-base`. * Drop the ad-hoc caching in favour of Cabal caching.
erikd
force-pushed
the
erikd/gha-tweaking
branch
from
ad2394d to
fdbf565
Compare
Jimbo4350
approved these changes
Feb 27, 2024
Previously the GHAs would store the cache after building the dependencies but never restore them. Did a thorough investigation of the issue and added proper comments about how it works and why.
erikd
force-pushed
the
erikd/gha-tweaking
branch
from
fdbf565 to
924711b
Compare
carbolymer
reviewed
Feb 27, 2024
| ${{ steps.setup-haskell.outputs.cabal-store }} | ||
| dist-newstyle | ||
| key: cache-${{ env.CABAL_CACHE_VERSION }}-${{ runner.os }}-${{ matrix.ghc }}-${{ hashFiles('dependencies.txt') }} | ||
| restore-keys: | |
There was a problem hiding this comment.
What's the purpose of of restore-keys here? Shouldn't key be enough?
There was a problem hiding this comment.
Not sure. THis cache restoration code was cargo culted from elsewhere. I can try deleting it if you like, see if it still works.
There was a problem hiding this comment.
Left over garbage from where I cargo-culted this from.
PR to remove it at: #628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Improve and simplify GHA.
Checklist