Switch to using cardano-git-rev from cardano-base repo #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
requested review from
Jimbo4350,
newhoggy,
carbolymer,
kevinhammond and
disassembler
as code owners
erikd
commented
Mar 12, 2024
| @@ -90,7 +91,7 @@ runDisplayVersion = do | |||
| [ "cardano-cli ", renderVersion version | |||
| , " - ", Text.pack os, "-", Text.pack arch | |||
| , " - ", Text.pack compilerName, "-", renderVersion compilerVersion | |||
| , "\ngit rev ", gitRev | |||
| , "\ngit rev ", $(gitRev) | |||
There was a problem hiding this comment.
This is no longer a function, but a TH splice.
carbolymer
approved these changes
Mar 15, 2024
The version of `cardano-git-rev` in the `cardano-base` repo is a TH splice instead of a function, so it will always be executed/evaluated at the call site.
auto-merge was automatically disabled
March 16, 2024 04:06
Merge queue setting changed
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Golden test failing needs this fix: #655 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of
cardano-git-revin thecardano-baserepo (ie CHaP) is a TH splice instead of a function, so it will always be executed/evaluated at the call site.Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist