Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top level changelog, linking to cardano-cli one #770

Merged
merged 1 commit into from
May 20, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented May 17, 2024

Changelog

- description: |
     Add top level changelog symlink, linking to cardano-cli
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
   - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #769

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer marked this pull request as ready for review May 17, 2024 11:11
@smelc
Copy link
Contributor

smelc commented May 17, 2024

Will this work for users that clone the repo on Windows?

@carbolymer
Copy link
Contributor Author

@smelc Usually no, unless you enable some options https://stackoverflow.com/questions/5917249/git-symbolic-links-in-windows/59761201#59761201 😵

@carbolymer carbolymer added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@carbolymer carbolymer added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@carbolymer carbolymer merged commit d363518 into main May 20, 2024
22 of 23 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/add-changelog branch May 20, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing File Required by Governance
3 participants