Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove call to checkProtocolParameters #780

Closed

Conversation

smelc
Copy link
Contributor

@smelc smelc commented May 31, 2024

Changelog

- description: |
    Remove call to checkProtocolParameters and check deprecations in API are indeed unused
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

TODO

How to trust this PR

TODO

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/reduce-dependency-on-api-protocol-parameters branch from 3c32536 to 1efd9be Compare June 3, 2024 12:45
@smelc
Copy link
Contributor Author

smelc commented Jun 13, 2024

Integrated into #786

@smelc
Copy link
Contributor Author

smelc commented Jun 13, 2024

Closing as #786 was merged

@smelc smelc closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant