-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add output options flags to calculate-min-fee #824
Conversation
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/Transaction/CalculateMinFee.hs
Fixed
Show fixed
Hide fixed
48cd184
to
8115d70
Compare
8115d70
to
6e39c92
Compare
@@ -21,6 +25,11 @@ Available options: | |||
--reference-script-size NATURAL | |||
Total size in bytes of transaction reference scripts | |||
(default is 0). | |||
--output-json Format calculate-min-fee query output to JSON. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
calculate-min-fee
appears here, because the code for this flag is shared with queries.
If we want to remove the terms calculate-min-fee query
here, we need to generalize said parsers a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean query
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carbolymer> No I meant calculate-min-fee query
(Format output to JSON
would still be a fine message)
6e39c92
to
2b292bc
Compare
…-output-options Add output options flags to calculate-min-fee
Changelog
Context
How to trust this PR
Look at the added tests. Check they implement the expected behavior.
Checklist