Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output options flags to calculate-min-fee #824

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jul 4, 2024

Changelog

- description: |
    Add output options flags to calculate-min-fee
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

Look at the added tests. Check they implement the expected behavior.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/calculate-min-fee-add-output-options branch from 48cd184 to 8115d70 Compare July 4, 2024 15:17
@smelc smelc marked this pull request as ready for review July 4, 2024 15:18
@smelc smelc force-pushed the smelc/calculate-min-fee-add-output-options branch from 8115d70 to 6e39c92 Compare July 5, 2024 07:12
@smelc smelc changed the title Add output options flags to calculcate-min-fee Add output options flags to calculate-min-fee Jul 5, 2024
@@ -21,6 +25,11 @@ Available options:
--reference-script-size NATURAL
Total size in bytes of transaction reference scripts
(default is 0).
--output-json Format calculate-min-fee query output to JSON.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calculate-min-fee appears here, because the code for this flag is shared with queries.

If we want to remove the terms calculate-min-fee query here, we need to generalize said parsers a bit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean query right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carbolymer> No I meant calculate-min-fee query (Format output to JSON would still be a fine message)

@smelc smelc force-pushed the smelc/calculate-min-fee-add-output-options branch from 6e39c92 to 2b292bc Compare July 15, 2024 08:23
@smelc smelc added this pull request to the merge queue Jul 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 15, 2024
…-output-options

Add output options flags to calculate-min-fee
@smelc smelc removed this pull request from the merge queue due to a manual request Jul 15, 2024
@smelc smelc merged commit f5d0056 into main Jul 15, 2024
22 checks passed
@smelc smelc deleted the smelc/calculate-min-fee-add-output-options branch July 15, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] - add json option and or out-file option to calculate-min-fee
2 participants