Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for treasury donation. #832

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

CarlosLopezDeLara
Copy link
Contributor

We check that build-raw correctly fails to build the tx body if any of --current-treasury-value or treasury-donation is missing.

Changelog

- description: |
    Add tests for treasury donation.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
   - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

We check that build-raw correctly fails to build the tx body if any of --current-treasury-value or treasury-donation is missing.
@CarlosLopezDeLara CarlosLopezDeLara marked this pull request as draft July 10, 2024 21:18
@CarlosLopezDeLara CarlosLopezDeLara marked this pull request as ready for review July 11, 2024 04:07
@CarlosLopezDeLara CarlosLopezDeLara added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 13ad36d Jul 11, 2024
23 checks passed
@CarlosLopezDeLara CarlosLopezDeLara deleted the cl/test-donation-build-raw branch July 11, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants