Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-ping: report user friendly error on misconfiguration #893

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

coot
Copy link
Contributor

@coot coot commented Sep 12, 2024

Changelog

- description: |
    Show user friendly warning when `cardano ping` command is misconfigured.
# uncomment types applicable to the change:
  type:
    - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #49.

How to trust this PR

When using unix sockets, cardano-ping can only query tip or supported
versions, since the node-to-client protocol doesn't include keep-alive
mini-protocol.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few remarks with regards to naming. Thanks.

cardano-cli/src/Cardano/CLI/Run/Ping.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Run/Ping.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Commands/Ping.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Run/Ping.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Commands/Ping.hs Outdated Show resolved Hide resolved
@coot coot force-pushed the coot/cardano-ping-misconfiguration branch from 78bace6 to 32e8ff5 Compare September 13, 2024 06:38
@coot coot enabled auto-merge September 13, 2024 06:39
@coot coot force-pushed the coot/cardano-ping-misconfiguration branch from 32e8ff5 to 7fea7a9 Compare September 13, 2024 06:44
@coot coot force-pushed the coot/cardano-ping-misconfiguration branch from 7fea7a9 to 6ebdc97 Compare September 13, 2024 07:08
@coot coot added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 294c3b9 Sep 13, 2024
25 checks passed
@coot coot deleted the coot/cardano-ping-misconfiguration branch September 13, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - cardano-cli ping --unixsock not sending pings
3 participants