Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certificates to CLI interface in compatible transaction-sign #972

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Nov 18, 2024

Changelog

- description: |
    Add certificates to CLI interface in `compatible transaction-sign` 
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Requires:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/add-certs-to-compatible-transaction-sign branch 6 times, most recently from bd0fc1e to 26a1017 Compare November 26, 2024 16:45
@carbolymer carbolymer force-pushed the mgalazyn/fix/add-certs-to-compatible-transaction-sign branch from 26a1017 to dbc9255 Compare November 28, 2024 15:26
@carbolymer carbolymer force-pushed the mgalazyn/fix/add-certs-to-compatible-transaction-sign branch 3 times, most recently from b4b094c to 6473d28 Compare January 2, 2025 13:57
* Added reference test for `compatible conway transaction singed-transaction`
@carbolymer carbolymer force-pushed the mgalazyn/fix/add-certs-to-compatible-transaction-sign branch from 6473d28 to ac19e61 Compare January 3, 2025 16:41
@carbolymer carbolymer marked this pull request as ready for review January 3, 2025 16:48
@smelc smelc added the next-update Needs a dependency to be updated to be merged label Jan 6, 2025
(protocolUpdates, votes) :: (AnyProtocolUpdate era, AnyVote era) <-
caseShelleyToBabbageOrConwayEraOnwards
( const $ do
prop <- maybe (pure $ NoPParamsUpdate sbe) readUpdateProposalFile mUpdateProposal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's not possible to move this one out of the case, to share the code between the two branches?

@smelc
Copy link
Contributor

smelc commented Jan 6, 2025

Code LGTM ✔️

cc @Jimbo4350 for approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-update Needs a dependency to be updated to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants