Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datums and scripts to friendlyTxImpl #977

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Add datums and scripts to friendlyTxImpl #977

merged 4 commits into from
Jan 8, 2025

Conversation

palas
Copy link
Contributor

@palas palas commented Nov 25, 2024 •
edited
Loading

Changelog

- description: |
    Added datums and scripts to `friendlyTxImpl`, which translates into them being showed by `transaction view`.
  type:
  - feature

Context

friendlyTxBodyImpl wasn't exposing information about datums nor redeemers. This PR addresses it.

How to trust this PR

Changes to the tests give a lot of assurance. I would also check the format of the output JSON, and that the info that is displayed is extensive and clear. Also probably good to look at this PR in conjunction with IntersectMBO/cardano-api#689

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the enhancement New feature or request label Nov 25, 2024
@palas palas self-assigned this Nov 25, 2024
@palas palas mentioned this pull request Nov 25, 2024
Merged
3 tasks
@palas palas force-pushed the add-dats-and-scripts-to-friendlytx branch 2 times, most recently from 57d4bc7 to 759eaf7 Compare November 27, 2024 18:11
@palas palas added the next-update Needs a dependency to be updated to be merged label Nov 28, 2024
@palas palas force-pushed the add-dats-and-scripts-to-friendlytx branch from 759eaf7 to ba67090 Compare January 8, 2025 10:56
@palas palas removed the next-update Needs a dependency to be updated to be merged label Jan 8, 2025
@palas palas enabled auto-merge January 8, 2025 11:05
@palas palas added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit 56c5420 Jan 8, 2025
74 of 78 checks passed
@palas palas deleted the add-dats-and-scripts-to-friendlytx branch January 8, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@smelc smelc smelc approved these changes

@carbolymer carbolymer carbolymer approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

@palas palas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@palas @carbolymer @smelc @Jimbo4350