-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON schema checking functionality for DRep and Gov action metadata #995
base: master
Are you sure you want to change the base?
Conversation
0bba7fc
to
92bd7ee
Compare
92bd7ee
to
18fc533
Compare
I just took a look at the testfiles and i noticed the one which has the authors signed with method "cip-0008". The signature provided in this example is the COSE_SIGN1, ok. But the publicKey is not really the COSE_KEY, its only the public key. As CIP-0008 supports actually different methods, do we simply demand that the COSE_Key map label '1' (kty) is '1' (OKP) ? If so, is this written somewhere in the CIP-100 (and dependencies) ? Or should in the case of using method "cip-0008" the publickey actually be the COSE_Key ? |
Changelog
Context
The objective is addressing this issue: #906
This PR is based on
cardano-api
PR #713, which provides the required functionality, and this PR should not be merged until thecardano-api
PR gets released and the source repo stanza is removed.How to trust this PR
I think, checking the changes to the tests here is key, and the main part. The actual functionality is in
cardano-api
PR #713 (I would check that one together with this). The latest commit should also be pure refactoring.Checklist