Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests run in PropertyT (ResourceT IO) #997

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Make tests run in `PropertyT (ResourceT IO)`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
   - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Due to recent changes in hedgehog-extras-0.6.5.1, we need to have ResourceT in the monad stack for proper workspace cleanup workarounds. This PR adapts codebase for the new version of hedgehog-extras.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/make-tests-run-in-resourcet-io branch 4 times, most recently from 2e9a5fd to 9f0068b Compare December 24, 2024 10:59
@carbolymer carbolymer marked this pull request as ready for review December 24, 2024 11:00
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carbolymer carbolymer enabled auto-merge December 24, 2024 14:31
@carbolymer carbolymer force-pushed the mgalazyn/fix/make-tests-run-in-resourcet-io branch from 9f0068b to d45847e Compare December 24, 2024 14:43
@carbolymer carbolymer requested review from a team as code owners December 24, 2024 14:43
@carbolymer carbolymer force-pushed the mgalazyn/fix/make-tests-run-in-resourcet-io branch from d45847e to 4e95bbe Compare December 24, 2024 17:12
@carbolymer carbolymer added this pull request to the merge queue Dec 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 24, 2024
@carbolymer carbolymer force-pushed the mgalazyn/fix/make-tests-run-in-resourcet-io branch from 4e95bbe to 3ac097b Compare December 27, 2024 08:52
@carbolymer carbolymer enabled auto-merge December 27, 2024 08:52
@carbolymer carbolymer added this pull request to the merge queue Dec 27, 2024
@carbolymer carbolymer removed this pull request from the merge queue due to a manual request Dec 27, 2024
@carbolymer carbolymer merged commit 824a111 into master Dec 27, 2024
25 of 26 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/make-tests-run-in-resourcet-io branch December 27, 2024 11:42
@carbolymer
Copy link
Contributor Author

Force merging since hydra gets stuck and does not report statuses back.

@smelc
Copy link
Contributor

smelc commented Jan 2, 2025

Nice removing the constraint's bound 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants