Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using TxCert type family #4903

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Switch to using TxCert type family #4903

merged 1 commit into from
Feb 21, 2025

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Feb 21, 2025

Description

Instead of using the ConwayTxCert concrete type. This will be helpful when we start defining a new era.

Fixes #4899

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins requested a review from a team as a code owner February 21, 2025 00:57
@lehins lehins requested a review from teodanciu February 21, 2025 00:58
Instead of using the `ConwayTxCert` concrete type. This will be helpful
when we start defining a new era.
@lehins lehins force-pushed the lehins/switch-to-txcert branch from 3f4f6c0 to 871c3f3 Compare February 21, 2025 01:00
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lehins lehins merged commit 88a3f9f into master Feb 21, 2025
152 of 157 checks passed
@lehins lehins deleted the lehins/switch-to-txcert branch February 21, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change ConwayTxCert to TxCert in TxBody
2 participants