Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for query spo-stake-distribution #5932

Merged
merged 9 commits into from
Sep 4, 2024
Merged

Add test for query spo-stake-distribution #5932

merged 9 commits into from
Sep 4, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Jul 31, 2024 •
edited
Loading

Description

This PR adds a test for the new command query spo-stake-distribution.

Associated PRs:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@palas palas self-assigned this Jul 31, 2024
@palas palas requested a review from a team as a code owner July 31, 2024 21:41
This was referenced Jul 31, 2024
Merged
Merged
@palas palas force-pushed the query-spo-stake-distr-node branch from 89f3824 to 83326ab Compare August 1, 2024 12:01
@palas palas force-pushed the ensure-query-test-completeness branch from 15c80e1 to 48415a6 Compare August 1, 2024 12:01
@palas palas force-pushed the query-spo-stake-distr-node branch 2 times, most recently from 2ad707a to 5f407d5 Compare August 1, 2024 13:58
@palas palas requested review from a team as code owners August 1, 2024 13:58
@palas palas force-pushed the ensure-query-test-completeness branch 4 times, most recently from 29ffe92 to 0dcdd24 Compare August 2, 2024 20:55
@palas palas force-pushed the query-spo-stake-distr-node branch from 5f407d5 to 031a6dd Compare August 2, 2024 21:18
@palas palas force-pushed the ensure-query-test-completeness branch from 0dcdd24 to 11b85c2 Compare August 2, 2024 22:27
@palas palas force-pushed the query-spo-stake-distr-node branch from 031a6dd to a60336a Compare August 2, 2024 22:29
@palas palas force-pushed the ensure-query-test-completeness branch 3 times, most recently from 7550a06 to 99c1712 Compare August 7, 2024 18:32
Base automatically changed from ensure-query-test-completeness to master August 8, 2024 17:23
@palas palas force-pushed the query-spo-stake-distr-node branch from a60336a to 78da7be Compare September 3, 2024 22:40
@palas palas removed the DO NOT MERGE label Sep 3, 2024
@palas palas linked an issue Sep 3, 2024 that may be closed by this pull request
[FR] - Provide governance query for stake distribution IntersectMBO/cardano-cli#850
Closed
@palas palas added this pull request to the merge queue Sep 4, 2024
Merged via the queue into master with commit b8f38f5 Sep 4, 2024
23 checks passed
@palas palas deleted the query-spo-stake-distr-node branch September 4, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

Assignees

@palas palas

Labels
cardano-testnet enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Provide governance query for stake distribution
2 participants
@palas @carbolymer