Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cardano-testnet: Test plutus script cost calculation command #6097

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

cardano-testnet: Test plutus script cost calculation command #6097

wants to merge 10 commits into from

Conversation

palas
Copy link
Contributor

@palas palas commented Jan 30, 2025 •
edited
Loading

Description

This tests the first step towards addressing this issue: IntersectMBO/cardano-cli#945.

Related PRs:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@palas palas self-assigned this Jan 30, 2025
@palas palas requested a review from a team as a code owner January 30, 2025 17:31
@palas palas linked an issue Jan 30, 2025 that may be closed by this pull request
[FR] - Command to calculate the correct Plutus Script Costs offline IntersectMBO/cardano-cli#945
Open
@palas palas force-pushed the plutus-script-cost-calculation-cmd branch from 9810ae5 to f74a09d Compare January 30, 2025 17:36
This was referenced Jan 30, 2025
Merged
Open
carbolymer
carbolymer approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

cardano-testnet/test/cardano-testnet-test/files/plutus/v3/always-succeeds.plutus Show resolved Hide resolved
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/PlutusCostCalculation.hs Outdated Show resolved Hide resolved
@palas palas mentioned this pull request Jan 31, 2025
Open
@palas palas removed a link to an issue Jan 31, 2025
[FR] - Command to calculate the correct Plutus Script Costs offline IntersectMBO/cardano-cli#945
Open
@palas palas force-pushed the plutus-script-cost-calculation-cmd branch from 875fa52 to 6116d23 Compare February 3, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

Assignees

@palas palas

Labels
cardano-testnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command to calculate the correct Plutus Script Costs online
2 participants
@palas @carbolymer