Merge pull request #2396 from IntersectMBO/fix/2372--ada-quantities-f…

…ormat-should-avoid-thousands-when-the-total-is-0 fix(#2372): fix ada quantities format
IntersectMBO · Nov 20, 2024 · 1663f56 · 1663f56
2 parents 4ff3e14 + e27ab29
commit 1663f56
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@ changes.
 
 - Fix listing voted-on governance actions [Issue 2379](https://github.com/IntersectMBO/govtool/issues/2379)
 - Fix wronly displayed markdown on slider card [Issue 2263](https://github.com/IntersectMBO/govtool/issues/2316)
+- fix ada quantities format to avoid thousands when the total is 0 [Issue 2372](https://github.com/IntersectMBO/govtool/issues/2382)
 
 ### Changed
 

diff --git a/govtool/frontend/src/utils/adaFormat.ts b/govtool/frontend/src/utils/adaFormat.ts
@@ -14,12 +14,12 @@ export const correctVoteAdaFormat = (
 ) => {
   if (lovelace) {
     const ada = lovelace / LOVELACE;
+
     return ada.toLocaleString(locale, {
-      minimumFractionDigits: 3,
       maximumFractionDigits: 3,
     });
   }
-  return "0,000";
+  return "0";
 };
 
 export const correctDRepDirectoryFormat = (lovelace: number | undefined) => {

diff --git a/govtool/frontend/src/utils/tests/adaFormat.test.ts b/govtool/frontend/src/utils/tests/adaFormat.test.ts
@@ -66,19 +66,19 @@ describe("correctVoteAdaFormat", () => {
 
   test("Returns 0 for undefined lovelace value", () => {
     const lovelace = undefined;
-    const expectedResult = "0,000";
+    const expectedResult = "0";
     expect(correctVoteAdaFormat(lovelace, "en-US")).toBe(expectedResult);
   });
 
   test("Returns 0 for zero lovelace value", () => {
     const lovelace = 0;
-    const expectedResult = "0,000";
+    const expectedResult = "0";
     expect(correctVoteAdaFormat(lovelace, "en-US")).toBe(expectedResult);
   });
 
   test("Returns 0 for small lovelace value", () => {
     const lovelace = 123;
-    const expectedResult = "0.000";
+    const expectedResult = "0";
     expect(correctVoteAdaFormat(lovelace, "en-US")).toBe(expectedResult);
   });
 });