Merge pull request #2529 from IntersectMBO/staging

fix: fix wrong DRep voting conditions
IntersectMBO · Dec 16, 2024 · b5ac058 · b5ac058
2 parents 042caa0 + 81b3b7c
commit b5ac058
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -38,6 +38,7 @@ changes.
 - Fix scaling gov action votes on lower resolutions
 - Fix storing url missing length validation [Issue 2044](https://github.com/IntersectMBO/govtool/issues/2044)
 - Fix governance action details page crash on missing data [Issue 2511](https://github.com/IntersectMBO/govtool/issues/2511)
+- Fix wrong voting conditions for drep
 
 ### Changed
 

diff --git a/govtool/frontend/src/context/featureFlag.test.tsx b/govtool/frontend/src/context/featureFlag.test.tsx
@@ -124,7 +124,7 @@ describe("FeatureFlagProvider", () => {
       ).toBe(true);
     });
 
-    it("should hide DRep vote totals for MotionNoConfidence in full governance", () => {
+    it("should show DRep vote totals for MotionNoConfidence in full governance", () => {
       mockUseAppContext.mockReturnValue({
         ...mockUseAppContextReturnValue,
         isAppInitializing: false,
@@ -140,7 +140,7 @@ describe("FeatureFlagProvider", () => {
         result.current.areDRepVoteTotalsDisplayed(
           GovernanceActionType.NoConfidence,
         ),
-      ).toBe(false);
+      ).toBe(true);
     });
   });
 

diff --git a/govtool/frontend/src/context/featureFlag.tsx b/govtool/frontend/src/context/featureFlag.tsx
@@ -77,16 +77,10 @@ const FeatureFlagProvider = ({ children }: PropsWithChildren) => {
             !isSecurityGroup)
         );
       }
-      if (isFullGovernance) {
-        return ![
-          GovernanceActionType.NoConfidence,
-          GovernanceActionType.NewCommittee,
-          GovernanceActionType.NewConstitution,
-        ].includes(governanceActionType);
-      }
+
       return true;
     },
-    [isAppInitializing, isInBootstrapPhase, isFullGovernance],
+    [isAppInitializing, isInBootstrapPhase],
   );
 
   /**