Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/73-strange-governance-actions-appear #116

Merged
merged 2 commits into from
Feb 7, 2024
Merged

fix/73-strange-governance-actions-appear #116

merged 2 commits into from
Feb 7, 2024

Conversation

Sworzen1
Copy link
Contributor

@Sworzen1 Sworzen1 commented Feb 5, 2024 •
edited
Loading

List of changes

  • add DRepID into getProposals
  • refactor
  • unify drepid (DRepID in camelCase)

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Sworzen1 Sworzen1 linked an issue Feb 5, 2024 that may be closed by this pull request
Strange Governance Actions Appear #73
Closed
@Sworzen1 Sworzen1 changed the title unify drepid / refactor / add drepid into getProposals fix/73-strange-governance-actions-appear Feb 5, 2024
MSzalowski
MSzalowski approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Sworzen1 Sworzen1 merged commit 2664950 into develop Feb 7, 2024
1 of 3 checks passed
@Sworzen1 Sworzen1 deleted the fix/73-strange-governance-actions-appear branch February 7, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@kickloop kickloop Awaiting requested review from kickloop

Assignees
No one assigned
Labels
🖥 Frontend Frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange Governance Actions Appear
2 participants
@Sworzen1 @MSzalowski