Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/119 sole voter components unification #238

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Feat/119 sole voter components unification #238

merged 3 commits into from
Feb 26, 2024

Conversation

JanJaroszczak
Copy link
Contributor

@JanJaroszczak JanJaroszczak commented Feb 21, 2024 •
edited
Loading

List of changes

  • Majority of Sole Voter feature is done here. What is left is to adjust it to recent changes in GET drep/info endpoint which will be added in next PR.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@JanJaroszczak JanJaroszczak marked this pull request as ready for review February 22, 2024 11:17
MSzalowski
MSzalowski reviewed Feb 23, 2024
View reviewed changes
govtool/frontend/src/pages/RetireAsSoleVoter.tsx
</Box>
</Box>
</Background>
<CenteredBoxPageWrapper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with the wrapper

MSzalowski
MSzalowski approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

@JanJaroszczak JanJaroszczak merged commit 8949b87 into feat/119-i-want-to-vote-on-behalf-of-myself-become-a-drep Feb 26, 2024
1 check passed
@JanJaroszczak JanJaroszczak deleted the feat/119-sole-voter-components-unification branch February 26, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@jdyczka jdyczka jdyczka approved these changes

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@kickloop kickloop Awaiting requested review from kickloop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JanJaroszczak @jdyczka @MSzalowski