Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#2546): handle errors on fetching drep images #2548

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix(#2546): handle errors on fetching drep images #2548

merged 1 commit into from
Dec 18, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • handle errors on fetching drep images

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Dec 17, 2024 that may be closed by this pull request
🐛 Fetching DReps images is throwing different errors in console #2546
Closed
@MSzalowski MSzalowski force-pushed the fix/2546-fetching-dreps-images-is-throwing-different-errors-in-console branch from 4ebd529 to b631d1a Compare December 17, 2024 13:28
@MSzalowski MSzalowski requested a review from placek December 17, 2024 13:29
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/2546-fetching-dreps-images-is-throwing-different-errors-in-console branch from b631d1a to 1f31e34 Compare December 18, 2024 08:14
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski merged commit cd26b58 into develop Dec 18, 2024
8 checks passed
@MSzalowski MSzalowski deleted the fix/2546-fetching-dreps-images-is-throwing-different-errors-in-console branch December 18, 2024 08:54
@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-cd26b58c187add854af1c5af000db12424e4520f , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-cd26b58c187add854af1c5af000db12424e4520f , for govtool-metadata-validation service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Fetching DReps images is throwing different errors in console
2 participants
@MSzalowski @placek