Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance dRep metadata handling with image and language support #2596

Merged
merged 1 commit into from
Jan 2, 2025
Merged

feat: enhance dRep metadata handling with image and language support #2596

merged 1 commit into from
Jan 2, 2025

Conversation

kneerose
Copy link
Contributor

@kneerose kneerose commented Jan 2, 2025

List of changes

  • Add language and image support on the test dRep register

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

✅ All checks succeeded

@kneerose kneerose requested a review from mesudip January 2, 2025 06:53
mesudip
mesudip approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@kneerose kneerose merged commit fe20807 into develop Jan 2, 2025
10 of 14 checks passed
@kneerose kneerose deleted the chore/update-metadata-format branch January 2, 2025 08:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

@kneerose
This PR is in the tag: develop-fe208077c4174432b83097168c91dd6b84f9c3bd , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

@kneerose
This PR is in the tag: develop-fe208077c4174432b83097168c91dd6b84f9c3bd , for govtool-frontend service

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

@kneerose
This PR is in the tag: develop-fe208077c4174432b83097168c91dd6b84f9c3bd , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @mesudip