Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#358] [#359] [#151] feat/358-choose-a-governance-action-type #383

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

Sworzen1
Copy link
Contributor

@Sworzen1 Sworzen1 commented Mar 4, 2024

…ion modals

List of changes

Add:

  • Create create GA page
  • Add Choose GA type
  • Display modal for abandoning registration as drep and GA creation

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Sworzen1 Sworzen1 marked this pull request as ready for review March 4, 2024 19:40
This was linked to issues Mar 4, 2024
@Sworzen1 Sworzen1 changed the title [#358] [#359] [#151] feat/358-choose-a-governance-action-type Mar 4, 2024
@Sworzen1 Sworzen1 linked an issue Mar 4, 2024 that may be closed by this pull request
@Sworzen1 Sworzen1 changed the title feat/358-choose-a-governance-action-type [#358] [#359] [#151] feat/358-choose-a-governance-action-type Mar 4, 2024

const onSubmit = useCallback(async (values: createGovernanceActionValues) => {
setIsLoading(true);
console.log(values);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.log

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or add TODO that it will be removed in favor of submitting governance action to service/csl

@Sworzen1 Sworzen1 merged commit 6b17aaa into develop Mar 5, 2024
1 check passed
@Sworzen1 Sworzen1 deleted the 358-choose-a-governance-action-type branch March 5, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥 Frontend Frontend related
Projects
None yet
2 participants