-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync test with recent develop #435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages tagging This commit modifies the build-and-deploy workflow file to include fetching the full history of the repository during deployment. This change is essential for accurately calculating the Docker image tags for both backend and frontend components in the CI/CD pipeline. By setting the `fetch-depth` to 0 in the step that checks out the code, the workflow now ensures that all historical commits are available, enabling precise version information retrieval for tagging the Docker images. Changes made: - Modified: .github/workflows/build-and-deploy.yml to add `fetch-depth: 0` parameter in the step that checks out the code, ensuring full repository history is fetched during deployment.
This commit adds logging of target indicators during the deployment process to improve visibility and tracking of deployment steps. Changed the deployment workflow in .github/workflows/build-and-deploy.yml to include target indicators logging when performing certain actions, such as destroying the Cardano Node and DB sync, deploying the application, and reprovisioning Grafana. The changes involve adding the '--debug=w' flag to the 'make' commands for destroying Cardano Node and DB sync, deploying the application, and reloading Grafana, allowing for more detailed logging during these actions.
This commit corrects the debug option in make commands in the CI/CD pipeline workflow, so that the deployment process in the CI can execute without issues related to unrecognized debug flags. The existing 'make' commands were utilizing the debug flag '--debug=w' which was causing compatibility issues in the CI environment where 'why' debug option was not recognized. This commit addresses the problem by replacing the 'w' with 'b' in the relevant 'make' commands in the '.github/workflows/build-and-deploy.yml' file, ensuring smooth execution of the deployment tasks.
Added a grafana panel to track all the deploys on the target machines. This change was made to address Issue 361.
In order to ensure accurate deployment traceability, it is necessary to use the highest existing version of the Grafana dashboard incremented by 1. This adjustment is crucial as the target instances have intermediate versions beyond version 35, and leveraging the most current version will maintain consistency in the deployment process. Changes: - Updated the version of the Grafana dashboard to 44 in the `govtool.json` file under `scripts/govtool/config/templates/grafana-provisioning/dashboards/`. By adjusting the version number, we align the dashboard with the latest iteration, thereby enhancing traceability and ensuring compatibility with the current deployment environment.
MSzalowski
requested review from
placek,
adgud,
kickloop,
Sworzen1 and
JanJaroszczak
as code owners
March 8, 2024 12:42
pmbinapps
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#427
#364
#361