Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/365-handle-governance-action-creation-in-wallet-provider #439

Merged
merged 4 commits into from
Mar 11, 2024
Merged

feat/365-handle-governance-action-creation-in-wallet-provider #439

merged 4 commits into from
Mar 11, 2024

Conversation

Sworzen1
Copy link
Contributor

@Sworzen1 Sworzen1 commented Mar 8, 2024 •
edited
Loading

List of changes

  • governance action certs (info and treasury)

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Sworzen1 Sworzen1 marked this pull request as ready for review March 8, 2024 14:28
MSzalowski
MSzalowski requested changes Mar 8, 2024
View reviewed changes
govtool/frontend/src/context/wallet.tsx Outdated
// Create an anchor
const anchorURL = URL.new(url);
const anchorHash = AnchorDataHash.from_hex(hash);
const anchor = Anchor.new(anchorURL, anchorHash);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move it to the utility function that generates anchor and might be used across the wallet

govtool/frontend/src/context/wallet.tsx Outdated Show resolved Hide resolved
@Sworzen1 Sworzen1 linked an issue Mar 10, 2024 that may be closed by this pull request
Handle governance action creation in wallet provider #365
Closed
@Sworzen1 Sworzen1 merged commit 2c6e008 into develop Mar 11, 2024
1 check passed
@Sworzen1 Sworzen1 deleted the feat/365-handle-governance-action-creation-in-wallet-provider branch March 11, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@kickloop kickloop Awaiting requested review from kickloop

Assignees
No one assigned
Labels
🖥 Frontend Frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle governance action creation in wallet provider
2 participants
@Sworzen1 @MSzalowski