-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#378] feat: add hash and validation of the metadata #458
[#378] feat: add hash and validation of the metadata #458
Conversation
a0bdf70
to
6a97391
Compare
090033e
to
1cb99d2
Compare
message: | ||
"Your Governance Action may take a little time to submit to the chain.", | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd arrange alphabetically the keys within 'modals'.
|
||
return await buildTreasuryGovernanceAction(treasuryActionDetails); | ||
default: | ||
throw new Error("Invalid governance action type"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add this error message and the others above to en.ts
as we already have some errors there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not displayed to the end user
1cb99d2
to
854034f
Compare
List of changes
Co-delivered with @Sworzen1
What is not included in this PR
Checklist