Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#378] feat: add hash and validation of the metadata #458

Merged
merged 5 commits into from
Mar 14, 2024

Conversation

MSzalowski
Copy link
Contributor

@MSzalowski MSzalowski commented Mar 12, 2024

List of changes

Co-delivered with @Sworzen1

What is not included in this PR

  • feedback button is not implemented yet as it requires different usersnap implementation (based on react not GTM)
  • link on a modal is not displayed below the description as it would destroy other modals
  • user hash is not compared in validation function as it will be delivered via different issue (which makes the validation always faulty on this delivery)

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski requested review from Sworzen1 and removed request for Sworzen1 March 12, 2024 18:19
@MSzalowski MSzalowski force-pushed the feat/378-hash-and-validation-of-the-metadata branch 2 times, most recently from a0bdf70 to 6a97391 Compare March 13, 2024 13:50
This was linked to issues Mar 13, 2024
@MSzalowski MSzalowski force-pushed the feat/378-hash-and-validation-of-the-metadata branch from 090033e to 1cb99d2 Compare March 13, 2024 15:04
message:
"Your Governance Action may take a little time to submit to the chain.",
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd arrange alphabetically the keys within 'modals'.


return await buildTreasuryGovernanceAction(treasuryActionDetails);
default:
throw new Error("Invalid governance action type");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add this error message and the others above to en.ts as we already have some errors there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not displayed to the end user

@MSzalowski MSzalowski force-pushed the feat/378-hash-and-validation-of-the-metadata branch from 1cb99d2 to 854034f Compare March 14, 2024 07:26
@MSzalowski MSzalowski merged commit 318d29d into develop Mar 14, 2024
1 check passed
@MSzalowski MSzalowski deleted the feat/378-hash-and-validation-of-the-metadata branch March 14, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥 Frontend Frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash and validation of the metadata Information storage steps
3 participants