Merge pull request #153 from Invertus/SL-222/parameter-issue-fix

SL-222/ Parameter and naming fix
Invertus · Mar 14, 2024 · 4263151 · 4263151
2 parents 5fda3f3 + 821dc7f
commit 4263151
Showing 1 changed file with 3 additions and 16 deletions.
diff --git a/src/Service/SaferPayInitialize.php b/src/Service/SaferPayInitialize.php
@@ -109,7 +109,7 @@ public function buildRequest(
         $creationAfterInitialization = $this->configuration->getAsBoolean(SaferPayConfig::SAFERPAY_ORDER_CREATION_AFTER_AUTHORIZATION);
         $alias = $this->saferPayCardAliasRepository->getSavedCardAliasFromId($selectedCard);
 
-        $successUrl = $this->context->link->getModuleLink(
+        $returnUrl = $this->context->link->getModuleLink(
             $this->module->name,
             ControllerName::RETURN_URL,
             [
@@ -136,29 +136,16 @@ public function buildRequest(
             true
         );
 
-        $failUrl = $this->context->link->getModuleLink(
-            $this->module->name,
-            ControllerName::FAIL_VALIDATION,
-            [
-                'cartId' => $this->context->cart->id,
-                'secureKey' => $this->context->cart->secure_key,
-                'orderId' => $creationAfterInitialization ? 0 :Order::getOrderByCartId($cartId),
-                'moduleId' => $this->module->id,
-                'isBusinessLicence' => $isBusinessLicence,
-            ],
-            true
-        );
-
         $initializeRequest = $this->requestObjectCreator->create(
             $this->context->cart,
             $customerEmail,
             $paymentMethod,
-            $successUrl,
+            $returnUrl,
             $notifyUrl,
-            $failUrl,
             $this->context->cart->id_address_delivery,
             $this->context->cart->id_address_invoice,
             $this->context->cart->id_customer,
+            $isBusinessLicence,
             $alias,
             $fieldToken
         );