delete cart on fail

Invertus · Oct 23, 2024 · 4c716a8 · 4c716a8
1 parent f035583
commit 4c716a8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/controllers/front/failIFrame.php b/controllers/front/failIFrame.php
@@ -49,6 +49,14 @@ public function initContent()
     {
         parent::initContent();
 
+        $cart = new \Cart(Tools::getValue('cartId'));
+
+        /**
+         * Note: deleting cart prevents
+         * from further failing when creating order with same cart
+         */
+        $cart->delete();
+
         /** @var LoggerInterface $logger */
         $logger = $this->module->getService(LoggerInterface::class);
 

diff --git a/controllers/front/return.php b/controllers/front/return.php
@@ -290,12 +290,13 @@ private function getOrderId($cartId)
      */
     private function getRedirectionToControllerUrl($controllerName)
     {
+        $cartId = $this->context->cart->id ? $this->context->cart->id : Tools::getValue('cartId');
         return $this->context->link->getModuleLink(
             $this->module->name,
             $controllerName,
             [
-                'cartId' => $this->context->cart->id,
-                'orderId' => Order::getOrderByCartId($this->context->cart->id),
+                'cartId' => $cartId,
+                'orderId' => Order::getOrderByCartId($cartId),
                 'secureKey' => $this->context->cart->secure_key,
                 'moduleId' => $this->module->id,
             ]