Added fixes

Invertus · Oct 12, 2023 · 5638518 · 5638518
1 parent 3e38d3a
commit 5638518
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/saferpayofficial.php b/saferpayofficial.php
@@ -523,7 +523,7 @@ public function hookActionEmailSendBefore($params)
         $canSendOrderConfirmationEmail = $this->getService(\Invertus\SaferPay\Core\Order\Verification\CanSendOrderConfirmationEmail::class);
 
         if ($params['template'] === 'order_conf') {
-            return $canSendOrderConfirmationEmail->verify($order);
+            return $canSendOrderConfirmationEmail->verify($order, (int) $order->current_state);
         }
 
         if ($params['template'] === 'new_order') {
@@ -560,13 +560,13 @@ public function hookActionOrderStatusUpdate($params = [])
 
         $saferPayAuthorizedStatus = (int) Configuration::get(\Invertus\SaferPay\Config\SaferPayConfig::SAFERPAY_PAYMENT_AUTHORIZED);
         if ($orderStatus->id === $saferPayAuthorizedStatus && Configuration::get(\Invertus\SaferPay\Config\SaferPayConfig::SAFERPAY_SEND_NEW_ORDER_MAIL)) {
-            $mailService->sendNewOrderMail($order, $orderStatus->id);
+            $mailService->sendNewOrderMail($order, (int) $orderStatus->id);
         }
 
         /** @var \Invertus\SaferPay\Core\Order\Verification\CanSendOrderConfirmationEmail $canSendOrderConfirmationEmail */
         $canSendOrderConfirmationEmail = $this->getService(\Invertus\SaferPay\Core\Order\Verification\CanSendOrderConfirmationEmail::class);
 
-        if ($canSendOrderConfirmationEmail->verify($order)) {
+        if ($canSendOrderConfirmationEmail->verify($order, (int) $orderStatus->id)) {
             $mailService->sendOrderConfMail($order, (int)$orderStatus->id);
         }
     }

diff --git a/src/Core/Order/Verification/CanSendOrderConfirmationEmail.php b/src/Core/Order/Verification/CanSendOrderConfirmationEmail.php
@@ -27,30 +27,30 @@
 
 class CanSendOrderConfirmationEmail
 {
-    public function verify(\Order $order)
+    public function verify(\Order $order, $orderStatusId)
     {
         if (!\Configuration::get(\Invertus\SaferPay\Config\SaferPayConfig::SAFERPAY_SEND_ORDER_CONFIRMATION)) {
             return false;
         }
 
-        if (!$this->isOrderStatusValid($order)) {
+        if (!$this->isOrderStatusValid($orderStatusId)) {
             return false;
         }
 
         return true;
     }
 
-    private function isOrderStatusValid(\Order $order): bool
+    private function isOrderStatusValid($orderStatusId)
     {
-        if ((int) \Configuration::get(SaferPayConfig::SAFERPAY_PAYMENT_AUTHORIZED) === (int) $order->current_state) {
+        if ((int) \Configuration::get(SaferPayConfig::SAFERPAY_PAYMENT_AUTHORIZED) === (int) $orderStatusId) {
             return true;
         }
 
-        if ((int) \Configuration::get(SaferPayConfig::SAFERPAY_PAYMENT_COMPLETED) === (int) $order->current_state) {
+        if ((int) \Configuration::get(SaferPayConfig::SAFERPAY_PAYMENT_COMPLETED) === (int) $orderStatusId) {
             return true;
         }
 
-        if ((int) \Configuration::get(SaferPayConfig::STATUS_PS_OS_OUTOFSTOCK_PAID) === (int) $order->current_state) {
+        if ((int) \Configuration::get(SaferPayConfig::STATUS_PS_OS_OUTOFSTOCK_PAID) === (int) $orderStatusId) {
             return true;
         }