Merge pull request #122 from Invertus/SL-155/aborted-payment-issue

SL-155/aborted-payment-issue
Invertus · Aug 22, 2023 · a203e24 · a203e24
2 parents 7ea6f2f + 21ee441
commit a203e24
Show file tree

Hide file tree

Showing 4 changed files with 67 additions and 62 deletions.
diff --git a/controllers/front/notify.php b/controllers/front/notify.php
@@ -118,7 +118,7 @@ private function assertTransaction($cartId)
     {
         /** @var SaferPayTransactionAssertion $transactionAssert */
         $transactionAssert = $this->module->getService(SaferPayTransactionAssertion::class);
-        $assertionResponse = $transactionAssert->assert(Order::getOrderByCartId($cartId));
+        $assertionResponse = $transactionAssert->assert(Order::getOrderByCartId($cartId), true);
 
         return $assertionResponse;
     }

diff --git a/controllers/front/return.php b/controllers/front/return.php
@@ -60,18 +60,56 @@ public function postProcess()
             ]));
         }
 
-        Tools::redirect($this->context->link->getModuleLink(
-            $this->module->name,
-            $this->getSuccessControllerName($isBusinessLicence, $fieldToken),
-            [
-                'cartId' => $cartId,
-                'orderId' => $orderId,
-                'moduleId' => $moduleId,
-                'secureKey' => $secureKey,
-                'selectedCard' => $selectedCard
-            ],
-            true
-        ));
+        try {
+            $this->assertTransaction($orderId);
+
+            Tools::redirect($this->context->link->getModuleLink(
+                $this->module->name,
+                $this->getSuccessControllerName($isBusinessLicence, $fieldToken),
+                [
+                    'cartId' => $cartId,
+                    'orderId' => $orderId,
+                    'moduleId' => $moduleId,
+                    'secureKey' => $secureKey,
+                    'selectedCard' => $selectedCard,
+                ],
+                true
+            ));
+
+        } catch (Exception $e) {
+            PrestaShopLogger::addLog(
+                sprintf(
+                    'Failed to assert transaction. Message: %s. File name: %s',
+                    $e->getMessage(),
+                    self::FILENAME
+                )
+            );
+
+            Tools::redirect($this->context->link->getModuleLink(
+                $this->module->name,
+                'failValidation',
+                [
+                    'cartId' => $cartId,
+                    'orderId' => $orderId,
+                    'secureKey' => $secureKey,
+                ],
+                true
+            ));
+        }
+    }
+
+    /**
+     * @param $cartId
+     * @return AssertBody
+     * @throws Exception
+     */
+    private function assertTransaction($orderId)
+    {
+        /** @var SaferPayTransactionAssertion $transactionAssert */
+        $transactionAssert = $this->module->getService(SaferPayTransactionAssertion::class);
+        $assertionResponse = $transactionAssert->assert($orderId, false);
+
+        return $assertionResponse;
     }
 
     private function getSuccessControllerName($isBusinessLicence, $fieldToken)
@@ -88,4 +126,4 @@ private function getSuccessControllerName($isBusinessLicence, $fieldToken)
 
         return $successController;
     }
-}
+}
diff --git a/controllers/front/success.php b/controllers/front/success.php
@@ -21,9 +21,7 @@
  *@license   SIX Payment Services
  */
 
-use Invertus\SaferPay\Api\Enum\TransactionStatus;
 use Invertus\SaferPay\Controller\AbstractSaferPayController;
-use Invertus\SaferPay\Service\TransactionFlow\SaferPayTransactionAssertion;
 
 class SaferPayOfficialSuccessModuleFrontController extends AbstractSaferPayController
 {
@@ -51,49 +49,16 @@ public function postProcess()
             Tools::redirect($redirectLink);
         }
 
-        try {
-            // TODO The shopping cart should be locked to prevent problems with the notify.php process running at the same time.
-            // $this->assertTransaction($orderId);
-
-            Tools::redirect($this->context->link->getPageLink(
-                'order-confirmation',
-                true,
-                null,
-                [
-                    'id_cart' => $cartId,
-                    'id_module' => $moduleId,
-                    'id_order' => $orderId,
-                    'key' => $secureKey,
-                ]
-            ));
-        } catch (Exception $e) {
-            PrestaShopLogger::addLog(
-                sprintf(
-                    'Failed to assert transaction. Message: %s. File name: %s',
-                        $e->getMessage(),
-                    self::FILENAME
-                )
-            );
-
-            Tools::redirect($this->context->link->getModuleLink(
-                $this->module->name,
-                'failValidation',
-                [
-                    'cartId' => $cartId,
-                    'orderId' => $orderId,
-                    'secureKey' => $secureKey
-                ],
-                true
-            ));
-        }
-    }
-
-    private function assertTransaction($orderId)
-    {
-        /** @var SaferPayTransactionAssertion $transactionAssert */
-        $transactionAssert = $this->module->getService(SaferPayTransactionAssertion::class);
-        $assertionResponse = $transactionAssert->assert($orderId);
-
-        return $assertionResponse;
+        Tools::redirect($this->context->link->getPageLink(
+            'order-confirmation',
+            true,
+            null,
+            [
+                'id_cart' => $cartId,
+                'id_module' => $moduleId,
+                'id_order' => $orderId,
+                'key' => $secureKey,
+            ]
+        ));
     }
 }
diff --git a/src/Service/TransactionFlow/SaferPayTransactionAssertion.php b/src/Service/TransactionFlow/SaferPayTransactionAssertion.php
@@ -71,7 +71,7 @@ public function __construct(
      * @return AssertBody
      * @throws \Exception
      */
-    public function assert($orderId)
+    public function assert($orderId, $changeOrderStatus)
     {
         $saferPayOrder = $this->getSaferPayOrder($orderId);
         $order = new Order($orderId);
@@ -87,7 +87,9 @@ public function assert($orderId)
         $saferPayOrder->transaction_id = $assertBody->getTransaction()->getId();
         $saferPayOrder->update();
 
-        $this->orderStatusService->assert($order, $assertBody->getTransaction()->getStatus());
+        if ($changeOrderStatus) {
+            $this->orderStatusService->assert($order, $assertBody->getTransaction()->getStatus());
+        }
 
         return $assertBody;
     }