Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Story 18705 gemify appraisal script #2

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Story 18705 gemify appraisal script #2

merged 7 commits into from
Jun 26, 2024

Conversation

dcaddell
Copy link
Contributor

@dcaddell dcaddell commented Jun 26, 2024 •
edited
Loading

This gem provides the functionality that's currently specified by our gem ci best practices.

TODO

We still want to add options for

  • Specifying a maximum gem version
  • Having more fine-grained support for which versions to include in the matrix
  • Exclude specific versions or combinations from the final matrix?

[0.1.0]

Added

  • Add an extension to the Appraisal gem that provides an interface for generating a matrix of appraisals.

jebentier
jebentier approved these changes Jun 26, 2024
View reviewed changes
Copy link

@jebentier jebentier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is solid! Excited for this to be public! Great work 🎉

@dcaddell dcaddell merged commit ab31bb5 into main Jun 26, 2024
5 checks passed
@dcaddell dcaddell deleted the STORY-18705_gemify_appraisal_script branch June 26, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jebentier jebentier jebentier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcaddell @jebentier