Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for rails 7.0 #14

Merged
merged 3 commits into from
Oct 24, 2024
Merged

add support for rails 7.0 #14

merged 3 commits into from
Oct 24, 2024

Conversation

ttstarck
Copy link
Contributor

@ttstarck ttstarck commented Oct 23, 2024

Add support for Rails 7.0, so PNAPI can upgrade to 7.0 👍

@ttstarck ttstarck marked this pull request as ready for review October 23, 2024 17:39
@ttstarck ttstarck requested a review from a team as a code owner October 23, 2024 17:39
@ttstarck ttstarck requested a review from dcaddell October 23, 2024 17:39
Copy link
Collaborator

@dcaddell dcaddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but don't we need this branched off of the 0.3 branch?

@ttstarck
Copy link
Contributor Author

@dcaddell 0.3 branch is the new branch that is supporting Rails 7.0 for EventMachine.

This PR is bumping v1 side of this gem for Rails 7.0

@ttstarck ttstarck requested a review from dcaddell October 23, 2024 23:54
Copy link
Collaborator

@dcaddell dcaddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you already released the support for the EM side. Got it!

@ttstarck ttstarck merged commit 268e73f into master Oct 24, 2024
25 of 26 checks passed
@ttstarck ttstarck deleted the add_rails_7_0_support branch October 24, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants