-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issues #34 #35
fix issues #34 #35
Conversation
TODO
|
src/dai.js
Outdated
let on_data; | ||
let push_data; | ||
if (!Array.isArray(option[df_list][i])) { | ||
df_name = option[df_list][i].name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
所以做命名規則的轉換是在哪裡?
這邊我看起來沒有做。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因為我 df_func_name() 的命名轉換是依照 Python 的方式寫的,所以使用在 push_data() 和 on_data() 中,我會修改成寫在 parse_df_profile() 中,這樣的方式會將 sa 傳進來的 _[A-Z]?(I|O)[0-9]?
function.name 轉換成 -[A-Z]?(I|O)[0-9]?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
哦 ok
Thanks for your contribution. |
context.js
dan2.js
dai.js
- 部分功能未實作 function
- 完全未實作 function