Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues #34 #35

Merged
merged 30 commits into from
Apr 12, 2021
Merged

fix issues #34 #35

merged 30 commits into from
Apr 12, 2021

Conversation

JasonChenGt
Copy link
Contributor

@JasonChenGt JasonChenGt commented Feb 25, 2021

context.js

this._mqueue = queue.Queue()  
# storing the MQTTMessageInfo from ``publish``
  • 未實作

dan2.js

def _on_offline_pub(self, client, userdata, mid):
  • 未實作
export const register = function (url, params, callback) 
  • 未實作 UUID 的類型與正確性比對

dai.js

- 部分功能未實作 function

function push_data(df_name)
  • 尚未實作 NoData 比對
function check_parameter()
  • 未實作 device_addr UUID 的類型與正確性比對

- 完全未實作 function

def start(self, *args, **kwargs):
def wait(self):
def terminate(self, *args, **kwargs):

@JasonChenGt JasonChenGt requested a review from iblislin March 1, 2021 14:43
src/context.js Outdated Show resolved Hide resolved
src/context.js Outdated Show resolved Hide resolved
src/context.js Outdated Show resolved Hide resolved
@JasonChenGt JasonChenGt requested a review from iblislin March 9, 2021 01:18
src/device-feature.js Outdated Show resolved Hide resolved
@JasonChenGt JasonChenGt requested a review from iblislin March 9, 2021 12:29
src/exceptions.js Outdated Show resolved Hide resolved
src/dai.js Outdated Show resolved Hide resolved
@JasonChenGt JasonChenGt requested a review from iblislin March 10, 2021 15:48
src/dai.js Outdated Show resolved Hide resolved
src/dai.js Outdated Show resolved Hide resolved
src/dai.js Outdated Show resolved Hide resolved
src/dai.js Outdated Show resolved Hide resolved
src/dai.js Outdated Show resolved Hide resolved
src/dai.js Outdated Show resolved Hide resolved
src/dan.js Outdated Show resolved Hide resolved
src/dan.js Outdated Show resolved Hide resolved
src/dan.js Outdated Show resolved Hide resolved
src/dan.js Show resolved Hide resolved
src/dan.js Outdated Show resolved Hide resolved
src/dan.js Show resolved Hide resolved
src/dan.js Outdated Show resolved Hide resolved
@JasonChenGt JasonChenGt requested a review from iblislin April 9, 2021 12:10
src/dan.js Outdated Show resolved Hide resolved
src/dan.js Outdated Show resolved Hide resolved
src/dai.js Outdated Show resolved Hide resolved
src/dai.js Outdated Show resolved Hide resolved
src/dai.js Outdated Show resolved Hide resolved
@iblislin
Copy link
Member

TODO

  • 待這個 PR 完成後,我會上 linter 然後跟修正 JS 的 naming style

src/dai.js Outdated
let on_data;
let push_data;
if (!Array.isArray(option[df_list][i])) {
df_name = option[df_list][i].name;
Copy link
Member

@iblislin iblislin Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所以做命名規則的轉換是在哪裡?
這邊我看起來沒有做。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因為我 df_func_name() 的命名轉換是依照 Python 的方式寫的,所以使用在 push_data() 和 on_data() 中,我會修改成寫在 parse_df_profile() 中,這樣的方式會將 sa 傳進來的 _[A-Z]?(I|O)[0-9]? function.name 轉換成 -[A-Z]?(I|O)[0-9]?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦 ok

@iblislin
Copy link
Member

Thanks for your contribution.

@iblislin iblislin merged commit 6143be0 into IoTtalk:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants