ei-513 Add sharing feed data via a stream #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtermanis
reviewed
Nov 13, 2023
| @@ -36,6 +36,9 @@ service FeedAPI { | |||
| // Shares a new sample of data for the given feed which any (interest) subscribers can receive. | |||
| rpc ShareFeedData(ShareFeedDataRequest) returns (ShareFeedDataResponse) {} | |||
|
|
|||
| // Shares feed data over a stream, any sharing error will return the error and close the stream | |||
| rpc StreamFeedData(stream ShareFeedDataRequest) returns (ShareFeedDataResponse) {} | |||
There was a problem hiding this comment.
This should indicate that currently only streamed sharing of a single feed is supported
There was a problem hiding this comment.
Note: cannot share to different feeds over the same stream.
Will be added.
StephanieBracaloni
force-pushed
the
ei-513
branch
from
20b60ea to
15a0323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.