feat: EI-3417 - Data/meta per-twin allowlist check RPCs #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtermanis
commented
Oct 22, 2024
|
|
||
| // IsHostDataAllowed determines whether a remote host is allowed to perform data requests against the given twin. | ||
| // An example of a data request is interest.SendInputMessage | ||
| rpc IsHostDataAllowed(IsHostDataAllowedRequest) returns (IsHostDataAllowedResponse) {} |
There was a problem hiding this comment.
Note: The slight change suggestion to the RPC naming compared to what's in the ticket is intentional: I thought since the ontological terms talk about e.g. pub:hostMetadataAllowList, it might be more consistent to call it IsHost<Type>Allowed()
andyantrim
approved these changes
Oct 28, 2024
vtermanis
force-pushed
the
ei-3417-allow-rpc
branch
from
ddeb6bf to
7497015
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.