Add the IOTICS circle services #40
Conversation
proto/iotics/api/circle.proto
Outdated
| // Services only affect local resources. | ||
| service CircleAPI { | ||
|
|
||
| // UpsertCircle creates or update a circle with its metadata. |
There was a problem hiding this comment.
Creates or updates
(same for twin)
| // DeleteCircle deletes a circle. | ||
| rpc DeleteCircle(DeleteCircleRequest) returns (DeleteCircleResponse) {} | ||
|
|
||
| // Describes a circle. |
There was a problem hiding this comment.
(pedantic) Based on how the other ones are written, should this and the below one say e.g.:
"DescribeCircle describes a circle"?
There was a problem hiding this comment.
Before this was mandatory due to the previous linter we were using. But this information is redundant and annoying to maintain.
| } | ||
|
|
||
|
|
||
| message UpsertCircleRequest { |
There was a problem hiding this comment.
(unimportant) some of the other definitions also have a docstring for each message type. (So I added them for e.g. the ACL PR). But I also appreciate that they are self-explanatory.
There was a problem hiding this comment.
Yes same.
We prefer to go with consistency over "better" approach for the logic but we can stop adding redundant comments
StephanieBracaloni
force-pushed
the
ei-3422
branch
from
39ce3a4 to
b5a08d4
Compare
|
Thanks for the reviews |
Add IOTICS circle services:
The remaining one will be part of another PR