Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issues with recieving multiple rewards #930

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Fixed Issues with recieving multiple rewards #930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/com/iridium/iridiumskyblock/managers/IslandManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,9 @@ public List<TeamReward> getTeamRewards(Island island) {

@Override
public void addTeamReward(TeamReward teamReward) {
IridiumSkyblock.getInstance().getDatabaseManager().getTeamRewardsTableManager().addEntry(teamReward);
CompletableFuture.runAsync(() -> IridiumSkyblock.getInstance().getDatabaseManager().getTeamRewardsTableManager().save(teamReward)).thenRun(() ->
IridiumSkyblock.getInstance().getDatabaseManager().getTeamRewardsTableManager().addEntry(teamReward)
);
Comment on lines +782 to +784
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This saves the record to the database first, which will generate the Id field.

What was happening was the id wasnt set, so all defaulted to 0, and here https://github.com/Iridium-Development/IridiumSkyblock/blob/master/src/main/java/com/iridium/iridiumskyblock/managers/DatabaseManager.java#L85 You can see we are keying by the id.

So when we save, it actually does a save/update and will replace if the key is the same, but since we havent saved to the database yet, the key (Id) isnt set, so is 0, which means that it will override the other values

}

@Override
Expand Down
Loading