Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to releasing doc about making a git tag #130

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

skeet70
Copy link
Member

@skeet70 skeet70 commented Oct 25, 2023

No description provided.

RELEASING.md Outdated
@@ -22,7 +22,7 @@ We deploy the SDK to [Maven Central](https://search.maven.org/artifact/com.ironc
release process complete successfully.
- When the artifacts have been deployed, go to https://oss.sonatype.org, log in using the `icl-devops` username and
password from `sonatype-info.txt`, and find the new release in the _Staging Repositories_. Close that repository and then release it in order to actually push the package out to the public repo.
- Push your new version and CHANGELOG entry to GitHub.
- Push your new version and CHANGELOG entry to GitHub. Create a release in github and label it as latest.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it being labeled as latest is done just by not marking it as pre-release

@skeet70 skeet70 merged commit 778c84d into main Oct 25, 2023
7 checks passed
@skeet70 skeet70 deleted the releasing-git-tag branch October 25, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants